net/http: prevent incorrect redirections when the path contains %2F%2F #39171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of ServeMux incorrectly returns a 301 status code when the path contains URL-encoded data, and especially URL-encoded URLs. Fixes golang#21955
googlebot
added
the
cla: yes
|
This PR (HEAD: a7b1801) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/234657 to see it. Tip: You can toggle comments from me using the |
|
Message from Damien Neil: Patch Set 1: Code-Review-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/234657. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of ServeMux incorrectly returns a 301 status
code when the path contains URL-encoded data, and especially URL-encoded
URLs.
Fixes #21955
Before this change, an URL such as "/r/https%3A%2F%2Fgoogle.com" where always triggering a 301, which is a bug preventing to pass escaped URLs as path parameters (common for redirection services for instance).
Unlike the patch proposed (and never merged) in #21955, this implementation relies on URL.RawPath which looks designed for this kind of use case, and is less intrusive.